Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate_solid method wrong documentation #246

Open
RemDelaporteMathurin opened this issue Jun 1, 2022 · 1 comment
Open

rotate_solid method wrong documentation #246

RemDelaporteMathurin opened this issue Jun 1, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@RemDelaporteMathurin
Copy link
Member

RemDelaporteMathurin commented Jun 1, 2022

Just noticed while using the Shape.rotate_solid method that the solid argument was not optional, despite what's written in the docs.

def rotate_solid(self, solid: Optional[Workplane]) -> Workplane:

Should it have a default value?
Is it even needed in the method? it seems to be overwritten anyway.

solid = Workplane(self.workplane)

@RemDelaporteMathurin RemDelaporteMathurin added the documentation Improvements or additions to documentation label Jun 1, 2022
@RemDelaporteMathurin
Copy link
Member Author

Ah sorry it isn't overwitten but it seems like this method wasn't designed to be used outside of the class...

My use case is: I have a solid created outside of the paramak, I want to import it in a Shape instance and then rotate it with paramak methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant