Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Fix log 'Skipped 1 duplicate messages..' #24

Open
vasilky3 opened this issue Oct 9, 2023 · 1 comment
Open

Fix log 'Skipped 1 duplicate messages..' #24

vasilky3 opened this issue Oct 9, 2023 · 1 comment

Comments

@vasilky3
Copy link
Contributor

vasilky3 commented Oct 9, 2023

What i was trying to achieve is removing this annoying messages "Skipped 1 duplicate messages..":

2023-09-20 21:20:55.129 T:5172    debug <general>: [script.elementum.jackett] Jackett returned below response
2023-09-20 21:20:55.129 T:5172     info <general>: Skipped 1 duplicate messages..
2023-09-20 21:20:55.129 T:5172    debug <general>: [script.elementum.jackett] ===============================
2023-09-20 21:20:55.135 T:5172     info <general>: Skipped 1 duplicate messages..

As i understand the reason is:
in some cases we are using
from elementum.provider import log
and it's calls elementum plugin code:
https://github.com/vasilky3/plugin.video.elementum/blob/master/resources/site-packages/elementum/logger.py

meanwhile script.jackett logger also gets the same logger. And now we adding second handler to it.
I think it causes double printing.
More over if we are already using elementum.provider.log why creating one more logger it looks not DRY enough :)

I will revert changes. All this need to be done in separate PR.

Originally posted by @vasilky3 in #21 (comment)

@vasilky3
Copy link
Contributor Author

fixed in #32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant