-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature_request] Add tau_grav_hat to the franka_state_controller/franka_states #207
Comments
Altough, having the gravity torques show up in the |
tau_grav_hat
to the franka_state_controller/franka_states
Including it in the State Interface wont be an option, really, since this data is not published via the FCI and libfranka. We can only add fields into the Providing a topic seems possible, but I wonder how useful that would be. Most often you need this data in realtime for control, not? What speaks against the "ros_control"-way of doing this, i.e. claiming the model interface and getting the gravity term via |
@gollth Ah, if you're not planning to implement this in the FCI, then adding it to the franka_states indeed does not make sense. There is nothing wrong with using the |
Would definitely improve user experience but at the cost of diverging interfaces between real robot and simulation I'd say this is not worth it, especially if you can already get this information via the model interface otherwise. Feel free to reopen if new insights arise |
No problem! I agree. |
* commit 'f0ffba1a08a5a1c12e83f58e9599d49a15c1389b': CHANGE: Use splash screen & fixed frame for all example Rvizes ADD: CHANGELOG entry ADD: RViz splash screen FIX: Use `$(arg arm_id)` as fixed frame for RVIz display config ADD: Use new `robot.launch` in `panda.launch` & `fr3.launch` CHANGE: Rename franka_gazebo/launch/{panda -> robot}.launch FIX: Use new `feEnsureAsciiFileContents` helper
For one of my projects, I was looking for an easy way to retrieve the torque that is applied by Gravity on the panda_joints. I know that I can retrieve this by using the getGravity method of the franka_hw::FrankaModelInterface, but I think it would be a significant improvement if this parameter was included in the
franka_states
that is published by thefranka_state_controller
or in a separate topic like is done with theF_ext
parameter.https://github.com/rickstaa/franka_ros/blob/5341770c6db24cdf5acf1bd87e832cf9f60a1b5c/franka_hw/include/franka_hw/franka_model_interface.h#L122
I did not create an example pull request for this since there are several ways to implement this.
The text was updated successfully, but these errors were encountered: