-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce unique channel names #231
Comments
PR #239 checks uniqueness of channel labels in two cases:
We don't have, at the moment, a check upon reading a certain zarr attribute file (that would be relevant for OME-Zarr files that are written from outside fractal). Should we add it, or is it a minor point? |
We can have 2 backlog issues for the moment:
|
No need for an issue. It's a three-lines change, which currently looks like this (in other places):
Let's just decide where this check should be performed (we can do it in our call tomorrow), and add it right away. |
We assign channels names, they are labels in the omero metadata on the image level, e.g. "label": "DAPI".
Channel names should be one option on how a user can select a channel (see #211). For this to work, they will need to be unique.
Thus, we need to enforce the uniqueness when we parse them.
Given that channel names are an optional input (right?), multiplexing parsing should not name the channels just A01_C01, but 0_A01_C01 (acquisition_wavelenght_identifier) if no name was provided.
The text was updated successfully, but these errors were encountered: