Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the function that executes a WorkflowTask list #777

Closed
tcompa opened this issue Jul 6, 2023 · 1 comment
Closed

Simplify the function that executes a WorkflowTask list #777

tcompa opened this issue Jul 6, 2023 · 1 comment
Assignees

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jul 6, 2023

In view of #261, we may want to refactor the recursive_task_submission function. This currently has a recursive structure, where N tasks are split into (N-1) "dependency" tasks, plus the last one. And then the function is called recursively on the (N-2)+1 tasks, then on the (N-3)+1 tasks, and so on, until it receives a list of a single task and executes it.

We should check whether it's worth to make it flat.

Also: this function's extensive use of futures is partly useless, since we always wait for the future result before moving on to the next task.

We should check whether this can be simplified without loosing any functionality, since this will make work on #261 more transparent.

@tcompa tcompa self-assigned this Jul 6, 2023
@tcompa tcompa changed the title Flatten the function that executes a WorkflowTask list Simplify the function that executes a WorkflowTask list Jul 6, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Jul 17, 2023

Closed with #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant