Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep an up-to-date .pre-commit-config.yaml in template subdir #10

Open
imagejan opened this issue Apr 17, 2024 · 3 comments
Open

Keep an up-to-date .pre-commit-config.yaml in template subdir #10

imagejan opened this issue Apr 17, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@imagejan
Copy link
Member

Our current pre-commit.ci workflow updates the .pre-commit-config.yaml in the repository root, but doesn't check the file inside the template subfolder.

Also, we should consider using ruff (both check and format), remove redundant others (e.g. black), and maybe add a ruff.toml to the project template (if we want to deviate from defaults).

@tibuch
Copy link
Contributor

tibuch commented Oct 22, 2024

I don't know if there exists an easy way to automate this.

Maybe we can create a git workflow which copies the template, runs pre-commit update, and feeds the changes into the template?

Not sure if this is worth the effort, or if we just need to do it manually from time to time.

@imagejan imagejan added the help wanted Extra attention is needed label Oct 28, 2024
@imagejan
Copy link
Member Author

We activated the pre-commit.ci bot for example-project as well, so we need to remember updating it here whenever we merge a pre-commit PR on https://github.com/fmi-faim/example-project.

Leaving this open to track updates.

@tibuch
Copy link
Contributor

tibuch commented Nov 5, 2024

Updated with 372aecc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants