Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IType::Record type #77

Open
mikevoronov opened this issue Apr 24, 2021 · 0 comments
Open

Improve IType::Record type #77

mikevoronov opened this issue Apr 24, 2021 · 0 comments
Labels
A-core-runtime area: core runtime components A-interface-types area: interface types A-modules area: everything relate to how a module is prcessed before in Marine C-enchancement category: an issue proposing an enchacement or a PR with one

Comments

@mikevoronov
Copy link
Member

mikevoronov commented Apr 24, 2021

At the moment IType::Record contains only a record type id (u64) that should correspond to the IRecordType from the list of types embedded to a Wasm binary in an IT section. This is convinient for internal representations and was very convinient for prototyping at the early FCE stages.

But it has several flaws, one of the most important is that this doesn't allow to specify the exact type in host closures. So it's worth to be refactored and changed to Record(Vec<IType>).

@mikevoronov mikevoronov changed the title Change IType::Record type Improve IType::Record type Apr 24, 2021
@mikevoronov mikevoronov added C-enchancement category: an issue proposing an enchacement or a PR with one A-core-runtime area: core runtime components A-interface-types area: interface types A-modules area: everything relate to how a module is prcessed before in Marine labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core-runtime area: core runtime components A-interface-types area: interface types A-modules area: everything relate to how a module is prcessed before in Marine C-enchancement category: an issue proposing an enchacement or a PR with one
Projects
None yet
Development

No branches or pull requests

1 participant