Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in TF metrics #178

Open
LoyVanBeek opened this issue Mar 2, 2021 · 0 comments
Open

Code duplication in TF metrics #178

LoyVanBeek opened this issue Mar 2, 2021 · 0 comments

Comments

@LoyVanBeek
Copy link
Contributor

The metrics related to TF (distance, jerk, velocity, length) have a lot of code duplication between them.

In eg. CalculateTfAccelerationTranslation, vs CalculateTfDistanceTranslation only a few members are added and a few lines in get_data are different but mostly the same. Some basic inheritance can reduce a lot of duplication and reduce maintenance.

Might be related to #58 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LoyVanBeek