You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently run method triggers DataFrame clone internally, the idea behind that was to always duplicate the dataframe in order to make it reusable. However PHP clone is shallow, I tried to use deep copy library however readonly properties are not allowing for it.
The solution for this problem is to make DataFrame and Pipelines truly immutable, meaning that adding any new element should create entirely new DataFrame.
One thing to remember is that extractors should be always recreated as well, otherwise all instances of DataFrame will keep reference to the same extractor and only one instance will be able to use it.
This test should be a confirmation that dataframe is truly immutable:
Currently run method triggers DataFrame clone internally, the idea behind that was to always duplicate the dataframe in order to make it reusable. However PHP clone is shallow, I tried to use deep copy library however readonly properties are not allowing for it.
The solution for this problem is to make DataFrame and Pipelines truly immutable, meaning that adding any new element should create entirely new DataFrame.
One thing to remember is that extractors should be always recreated as well, otherwise all instances of DataFrame will keep reference to the same extractor and only one instance will be able to use it.
This test should be a confirmation that dataframe is truly immutable:
The text was updated successfully, but these errors were encountered: