Filter deleted accounts from stg table #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
fivetran-avinash
changed the base branch from
main
to
bugfix/filter-deleted-accounts
fivetran-avinash
assigned fivetran-avinash and brandonrf94 and unassigned fivetran-avinash
fivetran-avinash
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
@brandonrf94 Approved! Merging into a release branch, hope to have it out this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Brandon Leahy, Runway Financial
Link the issue/feature request which this PR is meant to address
#55
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Pull in the fivetran deleted flag and filter it out when generating the staging table.
How did you validate the changes introduced within this PR?
Which warehouse did you use to develop these changes?
Tested on our companies local dbt (snowflake)
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)