Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] pnpm hints that package exports are in the incorrect order #1589

Open
inlined opened this issue Jan 7, 2025 · 0 comments
Open

[JS] pnpm hints that package exports are in the incorrect order #1589

inlined opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
bug Something isn't working js

Comments

@inlined
Copy link
Member

inlined commented Jan 7, 2025

Describe the bug
pnpm build warns about our ordering of the exports fields

To Reproduce
Run pnpm build

Expected behavior
Clean build

Screenshots
Build produces warnings such as:

plugins/pinecone build$ npm-run-all build:clean check compile
[8 lines collapsed]
[1 lines collapsed]
│          ╵       ~~~~~~~
│   The "import" condition comes earlier and will be used for all "import" statements:
│     package.json:51:6:
│       51 │       "import": "./lib/index.mjs",
│          ╵       ~~~~~~~~
│   The "require" condition comes earlier and will be used for all "require" calls:
│     package.json:50:6:
│       50 │       "require": "./lib/index.js",
│          ╵       ~~~~~~~~~
│   The "import" condition comes earlier and will be used for all "import" statements:

Runtime (please complete the following information):

  • OS: MacOS
  • Version 14.7.2

** Node version

  • 20.11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working js
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant