new libarchive31 fails test

[dmacks]

On 10.13, the newly committed libarchive31-3.7.7-1 has:

The following tests FAILED:
	523 - libarchive_test_write_disk_hardlink (Failed)
Errors while running CTest

The .log reports:

test_write_disk_hardlink

/sw/build.build/libarchive31-3.7.7-1/libarchive-3.7.7/libarchive/test/test_write_disk_hardlink.c:205: 0 != r = archive_write_header(ad, ae)
      0=0 (0x0, 00)
      r = archive_write_header(ad, ae)=-25 (0xffffffffffffffe7, 01777777777777777777747)
    errno: 45
   detail: Can't create 'link5b'
/sw/build.build/libarchive31-3.7.7-1/libarchive-3.7.7/libarchive/test/test_write_disk_hardlink.c:256: File link5a has 1 links, expected 2
/sw/build.build/libarchive31-3.7.7-1/libarchive-3.7.7/libarchive/test/test_write_disk_hardlink.c:257: File should exist: link5b
/sw/build.build/libarchive31-3.7.7-1/libarchive-3.7.7/libarchive/test/test_write_disk_hardlink.c:257: Files link5a and link5b are not hardlinked
/sw/build.build/libarchive31-3.7.7-1/libarchive-3.7.7/libarchive/test/test_write_disk_hardlink.c:257: Summary: Failed 2 times

[nieder]

Is it reproducible? Is /sw/build.build on an external drive? What's the formatting on where ever /sw/build is?
It worked for me on 10.14.6/APFS

[dmacks]

Reproducible. Everything's on the same drive, Mac OS Extended/Journaled, with no funny links. I do have BuildPath in a place outside of /sw/src/, but even undoing that setting does not change the result.

[nieder]

Did the previous version pass tests (I don't know if it had that specific test)? Another thing would be if what ever is expected to make the hardlink is being shadowed by something else? coreutils-default?

[cooljeanius]

the libarchive build system can sometimes pick up dependencies outside of the specified installation prefix; maybe that has something to do with it?

[dmacks]

The previous version (3.4.0) was fine: 'link5b' is a newly added test. I have no 'coreutils-default' or older 'libarchive31' installed. This new test is conditional on HAVE_LINKAT. During the build:

-- Looking for linkat
-- Looking for linkat - found

which is indeed available (unistd.h and libSystem). Version 3.4.0 did not look for that symbol.