Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to add a field in the routes db to check if the given route has already been deployed. #14

Open
fdojurado opened this issue Feb 16, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fdojurado
Copy link
Owner

fdojurado commented Feb 16, 2022

This is needed to avoid sending duplicate routes.

Currently, we are saving the routes found using the routing algorithm in the historical-routes db, and we assume that previous routes in db have been already deployed.

However, this might not be always the case. We potentially need to use a flag to identify which routes have been deployed. This flag inherits the status from the historical routes.

One solution is to check if the routes already exist in the node. See issue #16

@fdojurado fdojurado self-assigned this Feb 16, 2022
@fdojurado fdojurado added the enhancement New feature or request label Feb 16, 2022
@fdojurado
Copy link
Owner Author

This is fixed in commit 8cc57cb

fdojurado added a commit that referenced this issue Feb 22, 2022
…ute doesn't exist we create a new entry in the "routes" field for that specific node. However, if it exist we don't do anything. This fixes issue #16 and issue #14.
@fdojurado
Copy link
Owner Author

This is fixed in commit 8cc57cb

This has to be revised as the "save_routes_db" method doesn't look properly for matches in the "routes" field of the "nodes" collection.

@fdojurado fdojurado reopened this Feb 22, 2022
@fdojurado
Copy link
Owner Author

One way to check if the routes already exist can be found in d7dcb05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant