Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build procedure to not require renaming directories of Visual Studio Install #4

Open
rajha-korithrien opened this issue Jul 11, 2018 · 1 comment

Comments

@rajha-korithrien
Copy link

This is not an issue so much as a suggestion.
I struggled with getting the cmake windows build working, because I kept hitting the compiler heap error C1060.
I found the fix to be:

  • ensure you ran vcvarsall.bat with the x64 argument:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
  • pass the -T flag to cmake.
cmake .. -A x64 -T host=x64 .....

For a run of cmake in an empty directory (doing an out of source build). This caused everything to be built using the x64 64-bit tool chain instead the x86 32-bit tool chain. I was then able to get a complete and clean build on windows. No need to rename directories.
I file this issue so you can have an easier time and change your instructions in README.md because your github comes up when googling building tensorflow on windows, so it will make things easier for other folks as well.

@faisalthaheem
Copy link
Owner

Hi Rajha

Could you please create a pull request, it would be nice to have you contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants