Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write the adjusted compaction_readahead_size to LOG #13252

Open
mdcallag opened this issue Dec 26, 2024 · 2 comments
Open

write the adjusted compaction_readahead_size to LOG #13252

mdcallag opened this issue Dec 26, 2024 · 2 comments
Assignees

Comments

@mdcallag
Copy link
Contributor

Expected behavior

The fix for bug 12038 reduces the run-time value used for compaction_readahead_size from the configured value when max_sectors_kb is smaller. But nothing is written to LOG to indicate this has been done. To make life easier for people who debug RocksDB such changes should be written to LOG, and written near the start of LOG adjacent to all of the other config options.

Actual behavior

Nothing is written to LOG.

Steps to reproduce the behavior

Run this long enough that compaction will start:

./db_bench --benchmarks=overwrite --num=$large-value
@mdcallag
Copy link
Contributor Author

The code is here, but if logging is done here then that happens during compaction and I want this logged at startup with the other config options.

@hx235 hx235 self-assigned this Dec 27, 2024
@hx235
Copy link
Contributor

hx235 commented Dec 27, 2024

Yeah this is a bit tricky because in the setup time we haven't changed this value. It's a copy per file options now within each compaction job. Given the possibility that we will revert the change of explicit system call as mentioned in #12038 and that could've obsoleted this issue, I will postpone this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants