Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approach for pages that do not exist #1686

Open
bjohansebas opened this issue Nov 18, 2024 · 12 comments
Open

Approach for pages that do not exist #1686

bjohansebas opened this issue Nov 18, 2024 · 12 comments
Labels

Comments

@bjohansebas
Copy link
Member

I open this issue to see if everyone or the majority agrees on redirecting the links of the pages that do not exist to English, as done in #1685. I'm asking this before launching that PR

@chrisdel101
Copy link
Contributor

chrisdel101 commented Nov 18, 2024

I like having an approach. My personal opinion is that English links should not be in other languages since it's hard to get back to the language (have to use back button). BUT I'm okay with this (English links) if that's the consensus. Better to be consistent :)
(And English is better than broken)

@bjohansebas
Copy link
Member Author

That's true, English is better than broken English, but this would be fixed in the future if translation automation is achieved.

@carlosstenzel
Copy link
Contributor

I agree, since we will have automatic translation, it is better to have one updated page in English, than several outdated pages.

@carlosstenzel
Copy link
Contributor

What do you think about having an icon for a translation page in the navbar?

Captura de Tela 2024-11-19 às 21 27 19
ref https://react.dev/

@peterdanwan
Copy link
Contributor

Hello all - I'm happy to implement any approach that is decided!

Just wanted to note that consistent link patterns might make it easier to Ctrl + F for future updates, since the links I added differ from the existing style of links.

image

@bjohansebas
Copy link
Member Author

What do you think about having an icon for a translation page in the navbar?

I think it's great! i was planning to do it soon, which is why i also opened the issue. i was thinking of redirecting the page the user is on to their language, but this could lead to several 404 errors since there are pages that haven’t been implemented yet.

Just wanted to note that consistent link patterns might make it easier to Ctrl + F for future updates, since the links I added differ from the existing style of links.

Yep, that's why, among other reasons, we should reach a consensus on this. Maybe @jonchurch and @crandmck can give us their opinion.

@bjohansebas
Copy link
Member Author

The only link I think we should have in English is the blog (I mean for the other languages). For the rest, we can add the page as they are reported. This way, we won’t forget over time, and in the future, when automation is in place, we won’t have to worry about this.

@chrisdel101
Copy link
Contributor

Then do we want #1685 to just remove those links rather replace them?

@carlosstenzel
Copy link
Contributor

I don't think removing it is a good practice

@bjohansebas
Copy link
Member Author

Then do we want #1685 to just remove those links rather replace them?

Adding those pages is what I mean

@chrisdel101
Copy link
Contributor

chrisdel101 commented Nov 23, 2024

I don't get it. Can you elaborate?

@bjohansebas
Copy link
Member Author

I mean adding the file with the content in English. That is, if /es/guide/migration does not exist, the file should be added to avoid generating a 404.

Therefore, we should not change the link in #1685 but rather add the content. The same applies to #1615, we should add the support pages.

The only content that cannot be translated (yet) is the blog, so in other languages, it makes sense for the link to remain in English.

My message in Spanish

Me refiero a agregar el archivo con el contenido en inglés. Es decir, si /es/guide/migration no existe, se debe agregar el archivo para evitar que se genere un error 404,

Por lo tanto, no deberíamos cambiar el enlace en el #1685, sino más bien agregar el contenido. Lo mismo aplica para el #1615: deberíamos agregar las páginas de soporte.

El único contenido que no se puede traducir (todavía) es el blog, por lo que en otros idiomas tiene sentido que el enlace permanezca en inglés.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants