Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug de compilation sur phoenix_markdown #3499

Closed
thbar opened this issue Oct 2, 2023 · 5 comments · Fixed by #3542
Closed

Bug de compilation sur phoenix_markdown #3499

thbar opened this issue Oct 2, 2023 · 5 comments · Fixed by #3542
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité

Comments

@thbar
Copy link
Contributor

thbar commented Oct 2, 2023

Situation bizarre de compilation que j'ai rencontré en local:

❯ mix test
==> phoenix_markdown
Compiling 2 files (.ex)
error: Earmark.Options.__struct__/0 is undefined, cannot expand struct Earmark.Options. Make sure the struct name is correct. If the struct name exists and is correct but it still cannot be found, you likely have cyclic module usage in your code
  lib/phoenix_markdown/engine.ex:25: PhoenixMarkdown.Engine.compile/2


== Compilation error in file lib/phoenix_markdown/engine.ex ==
** (CompileError) lib/phoenix_markdown/engine.ex: cannot compile module PhoenixMarkdown.Engine (errors have been logged)
    (stdlib 3.17.2.4) lists.erl:1358: :lists.mapfoldl/3
could not compile dependency :phoenix_markdown, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile phoenix_markdown --force", update it with "mix deps.update phoenix_markdown" or clean it with "mix deps.clean phoenix_markdown"

Pas sûr de comment je suis tombé là dedans mais je note, et je vais aller commenter ici:

@thbar thbar added the dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité label Oct 2, 2023
@josevalim
Copy link

Bonjour, this PR should address it: boydm/phoenix_markdown#13

@thbar
Copy link
Contributor Author

thbar commented Oct 8, 2023

Thank you @josevalim!!!

@thbar
Copy link
Contributor Author

thbar commented Oct 16, 2023

Je tente d'obtenir un merge de PR sur le projet associé, dans l'espoir que ça corrige (problème sporadique).

Nos options principales sont:

  • obtenir une MAJ de la librairie
  • un petit fork dans etalab
  • un "vendoring" dans l'application vu que le code est petit

@AntoineAugusti
Copy link
Member

Tiens j'ai eu ce problème aussi, j'ai rm -rf _build et relancé

@AntoineAugusti
Copy link
Member

J'ai fait un fix sur scrivener_html aussi mgwidmann/scrivener_html#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants