Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define 'requests' in quota #8

Open
ethanpil opened this issue May 12, 2017 · 3 comments
Open

Define 'requests' in quota #8

ethanpil opened this issue May 12, 2017 · 3 comments

Comments

@ethanpil
Copy link

You state the free request limit is '30' per hour. Does that mean 30 files? 30 scans? 30 what?

@eriktorsner
Copy link
Owner

Hi,

You're right, this is not very clear in the current docs. Thanks for pointing that out.

A request is when the client asks for checksum info for one theme or plugin in your installation. So the number of plugins + the number of themes you have sums up to the number of requests needed for one complete sites.

Since the docs was last updated, the limit has been raised to 50/hour. That number will allow most (but not all) sites we've seen (so far) to have a free hourly scan.

Any feedback on this model is appreciated, we're eager to find a balance between being able to maintain an acceptable service level and providing a good service to the community.

@ethanpil
Copy link
Author

I think it makes sense for now.

Suggestions:

  1. Provide the limit information in the scan results:

API Limit: 50/hour | This Scan used XX credits | XX remaining this hour

  1. If we run out of API credit in the middle of a scan, it aborts. This wastes the entire scan time and credits used. If the scan aborts due to API limit, it should still provide results up to that point.

  2. If we do have more plugins/themes then remaining in our limit, it would be nice to be able to batch into X number of scans that can be performed over time.

For example
wp checksum plugin --batch-start=1 --batch-end=15 would scan the first 15 plugins
wp checksum plugin --batch-start=16 --batch-end=30 would scan the second 15 plugins

or maybe there is an even easier way...

@eriktorsner
Copy link
Owner

eriktorsner commented May 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants