Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier: Missing unit on uncertainty of identified time constant #162

Open
sondreew opened this issue Dec 2, 2024 · 0 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sondreew
Copy link
Contributor

sondreew commented Dec 2, 2024

When running the Identify() function on a dataset, the following output is part of the resulting parameters:
Image
Here the TimeConstant is printed with a time unit (seconds, hours, ....) depending on it's value. The uncertainty immediately following is not getting the same treatment, and in this case the TimeConstant value is explicitly given in hours while the uncertainty value does not have a unit stated but is (as far as I can tell) in seconds.
Suggested enhancement: add the unit to the TimeConstant uncertainty, and potentially have the value be transformed to the same unit as the identified TimeConstant value.

@sondreew sondreew added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant