Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-apps with metainfo component type of desktop application #95

Open
5 tasks
danirabbit opened this issue Aug 14, 2023 · 2 comments
Open
5 tasks

non-apps with metainfo component type of desktop application #95

danirabbit opened this issue Aug 14, 2023 · 2 comments

Comments

@danirabbit
Copy link
Member

danirabbit commented Aug 14, 2023

What Happened?

There are some compulsory components that currently have a metainfo component type of "desktop-application" even though they're not exactly apps:

  • Authentication Agent
  • Captive Network Assistant
  • Intial Setup
  • Notifications
  • Welcome

Steps to Reproduce

Change the component exclusion if statement for compulsories to include kind != DESKTOP_APPLICATION

Expected Behavior

These components should probably not declare themselves as "desktop-application" but its unclear to me what fits better.

Should they all be generic components with no "type" field?

Should "Authentication Agent", "Captive Network Assistant", and "Notifications" be considered a "service"?

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@danirabbit danirabbit added this to OS 8 Aug 14, 2023
@danirabbit danirabbit moved this to Needs Discussion in OS 8 Aug 14, 2023
@kerunaru
Copy link

What are the consequences of having those apps "declared" as desktop applications? 🤔

@danirabbit
Copy link
Member Author

Sorry that wasn't clear in the original report, the issue is that we want to avoid duplicates and avoid listing apps under the "desktop components" category. However if we exclude application type components that currently also will exclude some things that are miscategorized as apps

@danirabbit danirabbit removed this from OS 8 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants