Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Receive notifications for new voice messages #2108

Closed
1 of 5 tasks
Tracked by #2057
jonnyandrew opened this issue Oct 5, 2023 · 2 comments
Closed
1 of 5 tasks
Tracked by #2057

[Story] Receive notifications for new voice messages #2108

jonnyandrew opened this issue Oct 5, 2023 · 2 comments
Assignees
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@jonnyandrew
Copy link

jonnyandrew commented Oct 5, 2023

Description

Notifications for voice messages

Acceptance criteria

  • Tap notification to enter the relevant room
  • Notification content is the text representation of the voice message
    • Use the localized string common_voice_message for the notification body (and ignore the "fallback" event text representation)

Size estimate

None

Dependencies

Preconditions

No response

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Out of scope

  • Play voice message from the notification

Open questions

No response

Subtasks

Android

Preview Give feedback

iOS

Preview Give feedback

Other

Preview Give feedback
No tasks being tracked yet.
@alfogrillo
Copy link

alfogrillo commented Oct 11, 2023

Notification content is the text representation of the voice message

We typically use localized strings to represent media content.
On iOS we use common_voice_message for voice messages.
@jonnyandrew should we update the issue to make this clear?

@jonnyandrew
Copy link
Author

Good point, please feel free to update the issue. Let's follow the pattern of other media notifications.

@alfogrillo alfogrillo self-assigned this Oct 11, 2023
@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

4 participants