Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barren lands should always have 0 value #48

Open
teixeirak opened this issue Nov 3, 2018 · 8 comments
Open

barren lands should always have 0 value #48

teixeirak opened this issue Nov 3, 2018 · 8 comments

Comments

@teixeirak
Copy link
Contributor

Barren lands, by definition, have zero value from vegetation. Currently, I get this:

screen shot 2018-11-03 at 9 04 31 am

The fix is easy: simply add lines making biophysical_net, latent, and sw_radiative_forcing all =0 for barren vegetation types.
I believe the fix needs to go in this code.

@teixeirak
Copy link
Contributor Author

More fundamentally, the figure below shows non-zero values for net biophysics in the Sahara.
image

@ValentineHerr, would it be easy for you to edit the map files (.nc) to assign zero values to all barren lands?

@caseyhofford
Copy link
Contributor

caseyhofford commented Mar 31, 2020

OK, I think I have made this work. http://ghgvc.caseyhofford.com/ try out a few locations and let me know if the results look right. @teixeirak

@teixeirak
Copy link
Contributor Author

Looks good! Thank you!

@teixeirak teixeirak reopened this Apr 24, 2020
@teixeirak
Copy link
Contributor Author

@caseyhofford, I just tried a barren site in the Sahara (barren was indicated as the most likely cover type) and got non-zero biophysical values. I'm not sure what happened, as I thought this was fixed.

#48
image

@teixeirak
Copy link
Contributor Author

@ValentineHerr, would it be easy for you to edit the map files (.nc) to assign zero values to all barren lands?

This is done.

@ValentineHerr
Copy link
Contributor

Wait I think I went the easy way... You want the actual .nc files to be edited in the calculator, correct? I just visually put white on the .png maps, haha! I'll try to edit the .nc files now or on Monday. All underlying maps that need to be changed are in the "Box", right?

@teixeirak
Copy link
Contributor Author

What you did is perfect (for the map figure). (I didn't read my earlier comment about editing the .nc file carefully--sorry.) I think the optimal is actually just to set those to zero in the script, not change the .nc file. I think @caseyhofford had done this, but for some reason the problem re-appeared in the calculator.

@ValentineHerr
Copy link
Contributor

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants