From 16cd130bafd5b0395d3259143e1bf45b2484a581 Mon Sep 17 00:00:00 2001 From: ttl33 <19664986+ttl33@users.noreply.github.com> Date: Mon, 20 Nov 2023 06:48:02 -0800 Subject: [PATCH] [DEC-1106] Remove obsolete TODOs (#739) * remove obsolete todos * more obsolete todos --- protocol/app/constants.go | 1 - protocol/app/module/slashing.go | 4 ++-- protocol/app/prepare/metrics.go | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/protocol/app/constants.go b/protocol/app/constants.go index 9ad710e054..4bc034c743 100644 --- a/protocol/app/constants.go +++ b/protocol/app/constants.go @@ -1,7 +1,6 @@ package app const ( - // TODO(DEC-1106); rename `dydxprotocol` to `dydx` everywhere. AppName = "dydxprotocol" AppDaemonName = AppName + "d" ServiceName = "validator" diff --git a/protocol/app/module/slashing.go b/protocol/app/module/slashing.go index a6daaf4197..376e393a82 100644 --- a/protocol/app/module/slashing.go +++ b/protocol/app/module/slashing.go @@ -1,10 +1,11 @@ package module import ( - sdkmath "cosmossdk.io/math" "encoding/json" "time" + sdkmath "cosmossdk.io/math" + "github.com/cosmos/cosmos-sdk/codec" "github.com/cosmos/cosmos-sdk/x/slashing" @@ -18,7 +19,6 @@ type SlashingModuleBasic struct { } // DefaultGenesis returns custom `x/slashing` module genesis state. -// TODO(DEC-1776): Adjust below values based on final state of `Network Parameters` doc. func (SlashingModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage { genState := slashingtypes.DefaultGenesisState() diff --git a/protocol/app/prepare/metrics.go b/protocol/app/prepare/metrics.go index abb66cf2e6..6f7c0ede19 100644 --- a/protocol/app/prepare/metrics.go +++ b/protocol/app/prepare/metrics.go @@ -50,7 +50,6 @@ func recordSuccessMetrics(params successMetricParams) { ) // Funding tx. - // TODO(DEC-1254): add more metrics for Funding tx. telemetry.SetGauge( float32(params.fundingTx.NumVotes), ModuleName,