Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike | Raid Map config-based retrieval #76

Open
dvillavicencio opened this issue Feb 20, 2024 · 0 comments
Open

Spike | Raid Map config-based retrieval #76

dvillavicencio opened this issue Feb 20, 2024 · 0 comments
Labels
Design Issue related to design or architecture Refactor Refactoring code for better readability

Comments

@dvillavicencio
Copy link
Owner

The first version of the /raid_maps command uses an Enum class to represent all the given Raids that a user could request in a command. However, this enum also holds an attribute named directory which hardcodes the name of the directory which contains all the image and attachments to send through Discord chat. The same has been done for RaidEncounter. This task is to investigate if there is a better solution to hardcoding these file locations and instead use a configuration-based solution where each Raid enum instance has a property set in a .yaml file. This way, we can separate and de-couple the responsibility of having the file locations in the enum classes and instead externalize the locations to a configuration file.

@dvillavicencio dvillavicencio converted this from a draft issue Feb 20, 2024
@dvillavicencio dvillavicencio added Refactor Refactoring code for better readability Design Issue related to design or architecture labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issue related to design or architecture Refactor Refactoring code for better readability
Projects
Status: Backlog
Development

No branches or pull requests

1 participant