Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symlinks #4

Open
ayushr2 opened this issue Jun 6, 2019 · 2 comments · May be fixed by #5
Open

Add support for Symlinks #4

ayushr2 opened this issue Jun 6, 2019 · 2 comments · May be fixed by #5

Comments

@ayushr2
Copy link
Contributor

ayushr2 commented Jun 6, 2019

Currently symlinks are not supported because only inodes having extent trees are supported. According to Ext4 Disk Layout for symlinks, if the symlink contains a path shorter than 60 bytes then inode.i_block (Inode.IBlock in this lib) is used to store the path (which is usually the case). When that happens, the inode is not using extents and hence InodeFlagExtents is not set. Hence, this library refuses to create the symlink's inode. (Reference)
@ayushr2 ayushr2 closed this as completed Jun 11, 2019
@ayushr2 ayushr2 reopened this Jun 11, 2019
@ayushr2
Copy link
Contributor Author

ayushr2 commented Jun 11, 2019

The issue persists on this repo. I solve it in ayushr2/go-ext4#3.

@dsoprea
Copy link
Owner

dsoprea commented Jun 11, 2019

Feel free to open a PR here, then.

@ayushr2 ayushr2 linked a pull request Jun 12, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Symlink Support
2 participants
@dsoprea @ayushr2