Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists not set up properly for use as submodule. #18

Open
agribov opened this issue Oct 17, 2023 · 0 comments
Open

CMakeLists not set up properly for use as submodule. #18

agribov opened this issue Oct 17, 2023 · 0 comments

Comments

@agribov
Copy link

agribov commented Oct 17, 2023

There are a few problems with libuavcan CMakeLists.txt.

  1. There is no call to target_include_directories, meaning that when the user links to uavcan the user application cannot reference the uavcan include folder without adding this themselves. Should add:
target_include_directories(uavcan
        PUBLIC
        ${CMAKE_CURRENT_SOURCE_DIR}/libuavcan/include
        ${CMAKE_CURRENT_SOURCE_DIR}/libuavcan/include/dsdlc_generated/
)
  1. It always tries to build tests on debug builds. Should allow this to be turned on/off with a debug flag. Otherwise, this builds for all users who are including it as a submodule and making debug builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant