Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why do we keep a civicrm_stripe_plans table? Can we remove it? #238

Open
jmcclelland opened this issue Oct 18, 2017 · 0 comments
Open

why do we keep a civicrm_stripe_plans table? Can we remove it? #238

jmcclelland opened this issue Oct 18, 2017 · 0 comments

Comments

@jmcclelland
Copy link
Contributor

I was just bitten by #103 again and after considering the code, it seems like we can eliminate this table.

Then, for every plan, we first query stripe to see if it exists and if it doesn't we create it.

It seems that the only purpose of the plans table is to avoid this extra query. But the cost is losing a recurring contribution if something gets out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant