Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe must be default payprocessor to function #217

Closed
h-c-c opened this issue May 25, 2017 · 4 comments
Closed

Stripe must be default payprocessor to function #217

h-c-c opened this issue May 25, 2017 · 4 comments

Comments

@h-c-c
Copy link
Collaborator

h-c-c commented May 25, 2017

.....If it's not, you get the "Error: Stripe.js token was not passed!" message and can't process transactions. This could easily be play a role in any issue that references the above error message, eg #76, #179 and possibly #89.

CiviCRM has ways of "un-defaulting" your payprocessor decision, so it may not be obvious that the issue title is 100% accurate. For instance if you select Stripe (or any payprocessor) as your default, but don't check any accepted credit cards (visa/MC,AMEX,Discover), it has the same effect as not choosing Stripe as the default (totally reasonable!). Also, if you use a priceset with no default option, (as of May 25,'17), your default payprocessor choice will not be respected. (much less reasonable)

The reason is, we were failing to dynamically add the stripe-payment-form class with javascript. Not for long! :-)

h-c-c added a commit to h-c-c/com.drastikbydesign.stripe that referenced this issue May 25, 2017
@h-c-c h-c-c closed this as completed in 03ed1c3 May 25, 2017
@arborrow
Copy link

@h-c-c would you like me to test any scenario and verify that the patch fixes the issue? Let me know if there is anything I can do to be helpful.

@h-c-c
Copy link
Collaborator Author

h-c-c commented May 25, 2017

I did on this end...works for me. Go ahead, that would be awesome if you'd test it!

@arborrow
Copy link

I just commented on the commit that I tested it as well and it seems to work just fine, great work! Thanks for tracking down the issue and coming up with a fix.

@h-c-c
Copy link
Collaborator Author

h-c-c commented May 25, 2017

Thank you, and thanks for testing @arborrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants