-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe must be default payprocessor to function #217
Comments
@h-c-c would you like me to test any scenario and verify that the patch fixes the issue? Let me know if there is anything I can do to be helpful. |
I did on this end...works for me. Go ahead, that would be awesome if you'd test it! |
I just commented on the commit that I tested it as well and it seems to work just fine, great work! Thanks for tracking down the issue and coming up with a fix. |
Thank you, and thanks for testing @arborrow! |
.....If it's not, you get the "Error: Stripe.js token was not passed!" message and can't process transactions. This could easily be play a role in any issue that references the above error message, eg #76, #179 and possibly #89.
CiviCRM has ways of "un-defaulting" your payprocessor decision, so it may not be obvious that the issue title is 100% accurate. For instance if you select Stripe (or any payprocessor) as your default, but don't check any accepted credit cards (visa/MC,AMEX,Discover), it has the same effect as not choosing Stripe as the default (totally reasonable!). Also, if you use a priceset with no default option, (as of May 25,'17), your default payprocessor choice will not be respected. (much less reasonable)
The reason is, we were failing to dynamically add the stripe-payment-form class with javascript. Not for long! :-)
The text was updated successfully, but these errors were encountered: