Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore backup bigger than single cluster node fails #4357

Closed
moredure opened this issue Dec 23, 2024 · 0 comments · Fixed by #4394
Closed

Restore backup bigger than single cluster node fails #4357

moredure opened this issue Dec 23, 2024 · 0 comments · Fixed by #4394
Assignees
@BorysTheDev
Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue

Comments

@moredure
Copy link

moredure commented Dec 23, 2024 •
edited
Loading

Describe the bug
Backup file restore of the backup which size is bigger than single cluster node, but which will be restored to the node only partially and should not result in OOM, results in an error Out of memory, or used memory is too high.

To Reproduce

  1. Backup single node datastore with 50GB size
  2. Restore this backup into cluster with 2-3 shards where each shard will be 25GB size

Expected behavior
Backup restore should succeed and result in certain part of the keys from single file being restored to this cluster node where applied

Environment:

  • OS: [ubuntu 24.04]
  • DragonflyDB Cloud
  • Dragonfly Version: v1.26.0
@moredure moredure added the bug Something isn't working label Dec 23, 2024
@moredure moredure changed the title Restore Bigger Than Single Cluster Node Backup Fails Restore bigger than single cluster node backup fails Dec 23, 2024
@moredure moredure changed the title Restore bigger than single cluster node backup fails Restore backup bigger than single cluster node fails Dec 23, 2024
@adiholden adiholden added the Next Up task that is ready to be worked on and should be added to working queue label Dec 30, 2024
@BorysTheDev BorysTheDev mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow cluster node load snapshot bigger than maxmemory dragonflydb/dragonfly
3 participants
@BorysTheDev @moredure @adiholden