Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help getting environment set up to contribute #35

Open
roblevy opened this issue Nov 6, 2019 · 6 comments
Open

Help getting environment set up to contribute #35

roblevy opened this issue Nov 6, 2019 · 6 comments
Labels

Comments

@roblevy
Copy link

roblevy commented Nov 6, 2019

I'm interested in contributing to this repo, but I can't work out your development setup.

There's a tox.ini file, but that wants a setup.py file to run. There used to be a setup.py file but it got removed. Also, the tox.ini refers to requirements.txt but there isn't one as far as I can see!

There's something I'm missing but what is it? Sometimes repositories have some steps in their readme to get you started with development.

Can you help get me started?

@roblevy
Copy link
Author

roblevy commented Nov 6, 2019

Think I might have figured it out. I created a Python 3.6 virtual environment (needed? Not sure), pip installed poetry then ran poetry install. Does that sound about right?

@djrobstep
Copy link
Owner

Yeah sorry this is not documented very well! You are correct that it has been switched over to poetry.

I stopped using tox so that file can probably be removed, but the flake8 ignores defined in there will need moving to their own file first.

Once you have poetry installed and postgres running locally you should be OK. Do the tests pass for you now?

@roblevy
Copy link
Author

roblevy commented Nov 7, 2019

Thanks for the response! I'm getting

psycopg2.OperationalError: fe_sendauth: no password supplied

So I'm assuming I need an account with some particular login details. I'm investigating now what account details the tests expect. (I assume it's one with the same name as my linux login, but I think I've got such an account, with no password so there's something else going on...)

@roblevy
Copy link
Author

roblevy commented Nov 7, 2019

Ok, got there. I updated my pg_hba.conf file to include:

local   all             all                                     trust

And used sudo to log into psql and create a database with the same name as my Linux user. Now the tests are passing!

@djrobstep
Copy link
Owner

Great to hear. Should definitely have some better documentation for this.

@SKalt
Copy link

SKalt commented Jan 30, 2020

I drafted a CONRTIBUTING.md and migrated the flake8 config to setup.cfg in https://github.com/SKalt/schemainspect/tree/contributor-setup-instructions. Please feel free to use those patches as part of a larger setup instruction effort!

@maximsmol maximsmol added the docs label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants