[APP BUG]: Check for Updates crashes the shadPS4 QT application

[Resharcc]

Checklist

• I have searched for a similar issue in this repository and did not find one.
• I am using an official build obtained from releases or updated one of those builds using its in-app updater.

Describe the Bug

Seems related to shadps4-emu#1988

When checking for an update, the program seems to check for an update, and then stops responding. I can see the CPU usage pick up after doing this option, so something's happening.

I've tried the following:

• Running it normally
• Running it as an administrator
• Excluding the folder from Windows Defender

The folder path it's installed in doesn't have any spaces or malformed characters.

Reproduction Steps

1. Open up shadPS4
2. Click "Check for Updates" in Settings or in the Main UI

Expected Behavior

The program checks for an update and applies it if necessary.

Specify OS Version

Windows 10 22H2

[diegolix29]

Hi i have just auto updated all of the 3 channels and i didnt have this error, can u try donwloading and old build and replace the whole content like the 24 files, it will nos mess up ur save data or patches

[Resharcc]

I've downloaded this release and am facing the same error.

Interestingly, I went to 0.4.0 on the main shadPS4 repo, and that works as expected. I found this release which works.

Interestingly, if I update via the old version, then this problem doesn't occur on the new version. Even more interestingly, if you manually update it by replacing the files with the new version, then it works as expected.

However, if I delete the config file, then the behaviour reverts back to how it was before.

---

Here's the file diff of the two directories I was using:

$ diff -r broken-install/ working-install/
Only in working-install/user: addcont
diff -r broken-install/user/config.toml working-install/user/config.toml
9,11d8
< isPS4Pro = false
< BGMvolume = 50
< logFilter = ""
12a10,12
> logFilter = ""
> BGMvolume = 50
> isPS4Pro = false
14,16d13
< isTrophyPopupDisabled = false
< enableDiscordRPC = false
< logType = "async"
18c15,17
< updateChannel = ""
---
> logType = "async"
> enableDiscordRPC = false
> updateChannel = "PartBB"
21a21
> isTrophyPopupDisabled = false
50,53d49
< installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"]
< addonInstallDir = "F:\\Documents\\Emulators\\ISOs\\PS4"
< emulatorLanguage = "en"
< mw_width = 1280
55c51
< mw_height = 720
---
> mw_width = 1280
56a53,55
> geometry_x = 276
> gameTableMode = 0
> sliderPosGrid = 0
57a57
> mw_height = 720
59,61c59,60
< sliderPosGrid = 0
< geometry_x = 323
< gameTableMode = 0
---
> installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"]
> addonInstallDir = "F:\\Documents\\Emulators\\ps4-back\\user\\addcont"
63c62
< geometry_y = 139
---
> geometry_y = 103
67a67
> emulatorLanguage = "en"

Judging by this, it looks like the updateChannel value isn't being set when the initial config is written.

18c15,17
< updateChannel = ""
---
> logType = "async"
> enableDiscordRPC = false
> updateChannel = "PartBB"
21a21

Which seems to be the problem! When I clicked "Apply" to the settings, the problem disappears.

This seems to be because the updateChannel value has no default value (https://github.com/diegolix29/shadPS4/blob/main/src/common/config.cpp#L46), which was caused by this commit: 4e4f3d7

[Resharcc]

I'm going to cross-post this onto the other ticket I linked, as this appears to be the problem.