From fbcc927c527df2bfc4b35b369e841be56011e754 Mon Sep 17 00:00:00 2001 From: ff137 Date: Thu, 5 Dec 2024 22:52:55 +0200 Subject: [PATCH] :bug: Fix registering issuer did Should be called as the issuer, with `create_transaction_for_endorser=True`. Previously was being called as endorser and automatically written to ledger --- app/services/onboarding/issuer.py | 1 - app/services/onboarding/util/register_issuer_did.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/services/onboarding/issuer.py b/app/services/onboarding/issuer.py index 17f941b44..004e65961 100644 --- a/app/services/onboarding/issuer.py +++ b/app/services/onboarding/issuer.py @@ -115,7 +115,6 @@ async def onboard_issuer_no_public_did( ) issuer_did = await register_issuer_did( - endorser_controller=endorser_controller, issuer_controller=issuer_controller, issuer_label=issuer_label, logger=bound_logger, diff --git a/app/services/onboarding/util/register_issuer_did.py b/app/services/onboarding/util/register_issuer_did.py index 9d1fd63ba..52d418c94 100644 --- a/app/services/onboarding/util/register_issuer_did.py +++ b/app/services/onboarding/util/register_issuer_did.py @@ -162,7 +162,6 @@ async def configure_endorsement( async def register_issuer_did( *, - endorser_controller: AcaPyClient, issuer_controller: AcaPyClient, issuer_label: str, logger: Logger, @@ -171,10 +170,11 @@ async def register_issuer_did( issuer_did = await acapy_wallet.create_did(issuer_controller) await acapy_ledger.register_nym_on_ledger( - endorser_controller, + issuer_controller, did=issuer_did.did, verkey=issuer_did.verkey, alias=issuer_label, + create_transaction_for_endorser=True, ) logger.debug("Accepting TAA on behalf of issuer")