DEGIRO - Buy record in French (Belgium)

[jonathanR79]

I don't want to spam you with my third issue today but that one would be a nice improvement for Belgium people :-)

Here is a sample for a Buy record in French for Belgium:

Date,Heure,Date de,Produit,Code ISIN,Description,FX,Mouvements,,Solde,,ID Ordre
13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,Taxe sur les Opérations Boursières belge (TOB),,EUR,-0.45,EUR,8.31,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx
13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,Frais DEGIRO de courtage et/ou de parties tierces,,EUR,-1.00,EUR,8.76,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx
13-09-2024,10:36,13-09-2024,ISHARES ASIA PACIFIC DIVIDEND UCITS ETF,IE00B14X4T88,"Achat 18 iShares Asia Pacific Dividend UCITS ETF USD (Dist)@20,81 EUR (IE00B14X4T88)",,EUR,-374.58,EUR,9.76,72592e9b-xxxx-xxxx-xxxx-xxxxxxxxxxxx

When there are 3 lines, I never get a BUY record in the result.
When I keep 2 of those 3 lines, I get a BUY record but I never get a FEE record.

[dickwolff]

No worries, thanks for reporting these issues. This will indeed make sure Belgian users can also use the tool to it's full extent.

I added these lines to my sample file and I saw I previously added Frais DEGIRO de courtage et/ou de parties tierces (transaction fees) and Achat nn xxxxxxxxx@yy,yy EUR (ZZZZZZZZZZZZZZ). Taxe sur les Opérations is a new one, and that is also the one that breaks it.

Is this operation tax something specific for Belgian DEGIRO customers? I have not previously had a user that (made me aware of they have) had a transaction which had 3 relevant records attached.

[jonathanR79]

I don't know if France have something like this but it's in all my order.

I did found out in your code that this is not so new, it's present here:

Export-To-Ghostfolio/src/converters/degiroConverterV3.ts

Line 363 in 9aa4517

const transactionFeeRecordType = ["en\/of", "and\/or", "und\/oder", "e\/o", "adr\/gdr", "ritenuta", "belasting", "daň z dividendy", "taxe sur les", "impôts sur", "comissões de transação", "courtage et/ou"];

but I don't know if this is the correct place for it.

[dickwolff]

Yes, it's there. But you have 2 fee records attached to this one buy record. Which is weird to me, because normally it one or zero. The tool currently does not support 3 records activities (yet).

[jonathanR79]

ok thanks

[dickwolff]

Thanks, I will take a look at is and see if I can make something work. I will get back as soon as I have something you can test!

[jonathanR79]

I did try on my own but didn't succeed ;-)

[dickwolff]

I have a possible fix. The example in the issue above now gets converted to a single buy record using the sum of the transaction fee records as fee.

Can you verify this using this branch or this Docker image?

[jonathanR79]

Hello, there is an improvement as now buy record are processed but the fee calculation doesn't work al the time.

E.G:

   {
      "accountId": "8a0ba4dd-6791-460a-9b8c-0488e84b8507",
      "comment": "b3e0233a-fb5c-417d-88c2-12b22de02d7b",
      "fee": 244.78,
      "quantity": 68,
      "type": "BUY",
      "unitPrice": 24,
      "currency": "USD",
      "dataSource": "YAHOO",
      "date": "2024-03-21T09:26:00+01:00",
      "symbol": "JEPG.L"
    },

    21-03-2024,09:26,21-03-2024,JPM GLOBAL EQUITY PREMIUM INCOME,IE0003UVYC20,Taxe sur les Opérations Boursières belge (TOB),,EUR,-5.71,EUR,19.86,b3e0233a-xxxxx
21-03-2024,09:26,21-03-2024,JPM GLOBAL EQUITY PREMIUM INCOME,IE0003UVYC20,Frais DEGIRO de courtage et/ou de parties tierces,,EUR,-3.00,EUR,25.57,b3e0233a-xxxxx
21-03-2024,09:26,21-03-2024,JPM GLOBAL EQUITY PREMIUM INCOME,IE0003UVYC20,Achat 68 JPM Global Equity Premium Income UCITS ETF - USD (dist)@24 EUR (IE0003UVYC20),,EUR,-1632.00,EUR,28.57,b3e0233a-xxxxx

I also see again for some dividend:

"fee": null,

E.G:

 29-12-2023,18:47,29-12-2023,,,"Virement vers votre Compte Espèces à la flatexDEGIRO Bank AG: 0,53 EUR",,,,EUR,528.03,
29-12-2023,18:47,29-12-2023,FLATEX EURO BANKACCOUNT,NLFLATEXACNT,Degiro Cash Sweep Transfer,,EUR,-0.53,EUR,527.50,
29-12-2023,07:49,27-12-2023,VANGUARD FTSE DEVELOPED EUROPE,IE00B945VV12,Dividende,,EUR,0.53,EUR,528.03,

[dickwolff]

In #148 @ikruglov proposed some changes to improve the record matching. I believe it to be a better fix for this issue you have, as well be a general improvement on record matching. When that change is ready, I will ping you so you can verify if that is better.