From 99fe1615bfe0ef497ea65cc36611b54c8f231489 Mon Sep 17 00:00:00 2001 From: Paul Chen Date: Tue, 12 Dec 2023 00:07:04 +0800 Subject: [PATCH] fix: add missing unpack interfaces function for `LinkChainAccountPacketData` (#1277) ## Description Closes: #XXXX This PR fixed `LinkChainAccountPacketData` unmarshalling JSON issue that leads to fail to get the cached value for its `Any` fields. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- x/profiles/types/models_packets.go | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/x/profiles/types/models_packets.go b/x/profiles/types/models_packets.go index a172c0641a..5a4cdf22e3 100644 --- a/x/profiles/types/models_packets.go +++ b/x/profiles/types/models_packets.go @@ -65,3 +65,20 @@ func (p LinkChainAccountPacketData) Validate() error { func (p LinkChainAccountPacketData) GetBytes(cdc codec.Codec) ([]byte, error) { return sdk.SortJSON(cdc.MustMarshalJSON(&p)) } + +// UnpackInterfaces implements codectypes.UnpackInterfacesMessage +func (p *LinkChainAccountPacketData) UnpackInterfaces(unpacker codectypes.AnyUnpacker) error { + var address AddressData + if err := unpacker.UnpackAny(p.SourceAddress, &address); err != nil { + return err + } + + if err := p.SourceProof.UnpackInterfaces(unpacker); err != nil { + return err + } + + if err := p.DestinationProof.UnpackInterfaces(unpacker); err != nil { + return err + } + return nil +}