DST Staging Review: Storybook buttons say "button goes here"

[shiragoodman]

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Design System Staging Information

Component: Alert Sign-in
Staging Review ticket: Design System Staging Review: Alert Sign-in

Findings details

VA.gov Experience Standard - issue: User encounters consistent, clear design components and patterns.
VA.gov Experience Standard - category: Consistency
This is an issue with the: code
High-priority: No
Collab Cycle Reviewer: @erinrwhite (IA), @allison0034 (Design)

Description

In storybook, all the buttons for each iteration of the sign-in alert have some variation of the language "Button goes here" - including examples like verifying the account with ID.me or Login.gov that should use the same button design and text regardless of the application. It makes the Storybook documentation look unfinished.

Link, screenshot or steps to recreate

Recommended action

Update storybook buttons to use some kind of default button design/text, even if that text can be changed as a component variable.

References

• Accessibility Defect Severity: N/A
• WCAG Success Criteria: N/A
• Modality: N/A
• Design System Pattern or Template: N/A
• Design System Foundation: N/A
• Content Style Guide: N/A
• Context: N/A

---

Next Steps for DST

• Close the ticket when the issue has been resolved or validated by your Product Owner
• If your team has additional questions or needs Governance help validating the issue, please comment on the ticket
• If this ticket has a high-priority label, please address as soon as possible so VFS teams are not impacted
• If this ticket has a consider label, please consider for future implementation

[caw310]

Closing as @danbrady figured out a way to fix this which has been implemented. Thanks Dan!
https://design.va.gov/storybook/?path=/docs/components-va-alert-sign-in--docs