Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SaveInProgressInfo component and move into share component folder #178

Open
8 tasks
adamwhitlock1 opened this issue Oct 24, 2024 · 1 comment
Open
8 tasks
Assignees
Labels
Added [Pattern] Update their prefilled information Authenticated Experience Design Pattern

Comments

@adamwhitlock1
Copy link
Collaborator

User Story

As an engineer I would like to minimize repeated code and use shared components for different patterns where possible.

Background

The SaveInProgressInfo component could probably be one moved to the shared folder. A secondary task is to take a look at a few of the other repeated components and see where we can reduce repetition. Some initial ideas could be the ProfileInformationFieldController, and the custom navigation buttons that are used in the edit flow for a field.

ACs

  • Cleanup of repeated components between patterns/tasks

Review needed by

  • VA Product Owner
  • Product Manager
  • UX Research Team
  • Engineering Team

Definition of Done

  • Documentation has been updated, if applicable.
  • Acceptance Criteria in related issue are met.
  • Reviewers have approved.
@bellepx0
Copy link
Collaborator

After a discussion with Adam and further investigation, we have reassessed the urgency of this task. The component contains significant business logic. Refactoring would require more effort than we initially anticipated.

Moving this task out of the current sprint and into our backlog for now.

@msbtterswrth msbtterswrth mentioned this issue Nov 5, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added [Pattern] Update their prefilled information Authenticated Experience Design Pattern
Projects
None yet
Development

No branches or pull requests

3 participants