Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: avoid doubly storing vk for Proofs #182

Open
distractedm1nd opened this issue Dec 18, 2024 · 0 comments
Open

improvement: avoid doubly storing vk for Proofs #182

distractedm1nd opened this issue Dec 18, 2024 · 0 comments

Comments

@distractedm1nd
Copy link
Contributor

After the Account refactor, we now pass the vk in the Transaction. As this is also stored in the Account, it gets serialized twice inside of InsertProof/UpdateProof.

We could use key_idx like we did previously, but this should be done in a way that has a nice UX.

I am leaving it as an additional issue because this is an optimization that could damage UX and readability if we don't do it in a nice way.

Originally posted by @distractedm1nd in #180 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant