Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prince of Persia - some flickering garbage rendered in the upper few lines of the screen #73

Open
ESPboy-edu opened this issue Dec 20, 2022 · 5 comments
Labels
bug Something isn't working diff: complex A difficult issue; may require significant planning.

Comments

@ESPboy-edu
Copy link

ESPboy-edu commented Dec 20, 2022

Prince of Persia - some flickering garbage rendered in the upper few lines of the screen
used last release - peanut_gb.h
gb: fix BG over OBJ with colour 0

@deltabeard
Copy link
Owner

Confirmed. Do you know if this flickering occured in a previous version or did a recent change cause this?

@deltabeard deltabeard added the bug Something isn't working label Dec 20, 2022
@deltabeard
Copy link
Owner

I think the issue is that the VRAM address mode is not being switched back to 0x8800 mode in time after switching to 0x8000 mode for the text on the bottom of the screen. This seems to only occur on screens where there are animations (so the flicker stops when the game is paused).

Maybe the VRAM address mode change is initiated after the LCD begins drawing the line? This will require some investigation.

@deltabeard deltabeard added the diff: complex A difficult issue; may require significant planning. label Dec 20, 2022
@deltabeard
Copy link
Owner

Please try the latest commit (bbf094a).

@ESPboy-edu
Copy link
Author

Using last 88aacda
I see one blinking line at the bottom between main game screen and bottom status line (blinking somehow connected to the torches on the walls)

@deltabeard
Copy link
Owner

This issue still persists on the ppu-fix branch with commit fcb4268. The flickering is still on the bottom of the screen. No doubt because the timing of the PPU is still poor.
PRINCE_OF_PERSIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working diff: complex A difficult issue; may require significant planning.
Projects
None yet
Development

No branches or pull requests

2 participants