Typing //replace quartz crashes the server

[HelenaKitty]

Commit ID: 1c31cb7eecc92d2fb218da8948e3201b618a46d2
Minecraft Version: 1.11.2
WorldEdit Branches: Master, 'fillAndfillr'

Synopsis:

When specifying the right block name 'quartz_block' to the //replace command, the server doesn't crash and proceeds with replacing the block, however if 'quartz' is specified instead, the server dies. Specifying other unknown terms to the //replace command throws an error instead of crashing the server. Other terms I have found to cause this crash is 'diamond'.

Findings

Can only reproduce

Conclusion

Maybe there is a way of handling these crashes so that if an invalid (existing) block is specified to any of the commands.

Backtrace:

[10:43:52]   D:    | Cuberite has encountered an error and needs to close
[10:43:52] Details | SIGSEGV: Segmentation fault
[10:43:52] Cuberite local build build id: Unknown
[10:43:52] from commit id: approx: 1c31cb7eecc92d2fb218da8948e3201b618a46d2 built at: approx: 2017-02-22 13:10:32 +0000
./Cuberite(_Z15PrintStackTracev+0x14)[0x62f704]
./Cuberite[0x61b103]
/lib/x86_64-linux-gnu/libc.so.6(+0x350e0)[0x7fa26951f0e0]
/lib/x86_64-linux-gnu/libc.so.6(strlen+0x2a)[0x7fa26956bc3a]
./Cuberite[0x9b70ec]
./Cuberite(luaL_error+0xec)[0x9bc1fc]
./Cuberite[0x6d39bd]
./Cuberite[0x9b15f9]
./Cuberite[0x9c8dd7]
./Cuberite[0x9b1d8d]
[10:43:52] Kicking player dawnstar808 for "Server shutdown"
./Cuberite[0x9b0cb8]
./Cuberite[0x9b1fda]
./Cuberite(lua_pcall+0x44)[0x9b5ca4]
./Cuberite(_ZN9cLuaState12CallFunctionEi+0x3e)[0x6400ae]
./Cuberite(_ZN17LuaCommandHandler14ExecuteCommandERKSt6vectorISsSaISsEEP7cPlayerRKSsP22cCommandOutputCallback+0x10e)[0x6589ae]
./Cuberite(_ZN14cPluginManager13HandleCommandER7cPlayerRKSsb+0x169)[0x67a009]
./Cuberite(_ZN14cPluginManager12CallHookChatER7cPlayerRSs+0x1d)[0x67a1fd]
./Cuberite(_ZN13cClientHandle10HandleChatERKSs+0x33)[0x583bf3]
./Cuberite(_ZN15cProtocol_1_9_023HandlePacketChatMessageER11cByteBuffer+0x4e)[0x7570ae]
./Cuberite(_ZN15cProtocol_1_9_012HandlePacketER11cByteBufferj+0x431)[0x757af1]
./Cuberite(_ZN15cProtocol_1_9_015AddReceivedDataEPKcm+0x11c)[0x75b66c]
./Cuberite(_ZN15cProtocol_1_9_012DataReceivedEPKcm+0x68)[0x75c058]
./Cuberite(_ZN19cProtocolRecognizer12DataReceivedEPKcm+0x23)[0x766893]
./Cuberite(_ZN13cClientHandle20ProcessProtocolInOutEv+0x55)[0x586cf5]
./Cuberite(_ZN13cClientHandle4TickEf+0x24)[0x589e84]
./Cuberite(_ZN6cWorld11TickClientsEf+0x18b)[0x60ab8b]
./Cuberite(_ZN6cWorld4TickENSt6chrono8durationIlSt5ratioILl1ELl1000EEEES4_+0x2b0)[0x60c950]
./Cuberite(_ZN6cWorld11cTickThread7ExecuteEv+0x71)[0x60cc11]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb6970)[0x7fa26a07f970]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x8064)[0x7fa26989d064]
[10:43:52]   D:    | Cuberite has encountered an error and needs to close
[10:43:52] Details | SIGABRT: Server self-terminated due to an internal fault
[10:43:52] Cuberite local build build id: Unknown
[10:43:52] from commit id: approx: 1c31cb7eecc92d2fb218da8948e3201b618a46d2 built at: approx: 2017-02-22 13:10:32 +0000
./Cuberite(_Z15PrintStackTracev+0x14)[0x62f704]
./Cuberite[0x61b103]
/lib/x86_64-linux-gnu/libc.so.6(+0x350e0)[0x7fa26951f0e0]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x37)[0x7fa26951f067]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x148)[0x7fa269520448]
./Cuberite[0x61b108]
/lib/x86_64-linux-gnu/libc.so.6(+0x350e0)[0x7fa26951f0e0]
/lib/x86_64-linux-gnu/libc.so.6(strlen+0x2a)[0x7fa26956bc3a]
./Cuberite[0x9b70ec]
./Cuberite(luaL_error+0xec)[0x9bc1fc]
./Cuberite[0x6d39bd]
./Cuberite[0x9b15f9]
./Cuberite[0x9c8dd7]
./Cuberite[0x9b1d8d]
./Cuberite[0x9b0cb8]
./Cuberite[0x9b1fda]
./Cuberite(lua_pcall+0x44)[0x9b5ca4]
./Cuberite(_ZN9cLuaState12CallFunctionEi+0x3e)[0x6400ae]
./Cuberite(_ZN17LuaCommandHandler14ExecuteCommandERKSt6vectorISsSaISsEEP7cPlayerRKSsP22cCommandOutputCallback+0x10e)[0x6589ae]
./Cuberite(_ZN14cPluginManager13HandleCommandER7cPlayerRKSsb+0x169)[0x67a009]
./Cuberite(_ZN14cPluginManager12CallHookChatER7cPlayerRSs+0x1d)[0x67a1fd]
./Cuberite(_ZN13cClientHandle10HandleChatERKSs+0x33)[0x583bf3]
./Cuberite(_ZN15cProtocol_1_9_023HandlePacketChatMessageER11cByteBuffer+0x4e)[0x7570ae]
./Cuberite(_ZN15cProtocol_1_9_012HandlePacketER11cByteBufferj+0x431)[0x757af1]
./Cuberite(_ZN15cProtocol_1_9_015AddReceivedDataEPKcm+0x11c)[0x75b66c]
./Cuberite(_ZN15cProtocol_1_9_012DataReceivedEPKcm+0x68)[0x75c058]
./Cuberite(_ZN19cProtocolRecognizer12DataReceivedEPKcm+0x23)[0x766893]
./Cuberite(_ZN13cClientHandle20ProcessProtocolInOutEv+0x55)[0x586cf5]
./Cuberite(_ZN13cClientHandle4TickEf+0x24)[0x589e84]
./Cuberite(_ZN6cWorld11TickClientsEf+0x18b)[0x60ab8b]

[Seadragon91]

I can confirm that, passing a item instead of a block produces a error in the console.

12:07:31] LUA: Plugins/WorldEdit/functions.lua:320: error in function 'SetRelBlockTypeMeta'.
     argument #606905504 is array of '[no object]'; array of '<removed>' expected.

[12:07:31] Stack trace:
[12:07:31]   [C](-1): SetRelBlockTypeMeta
[12:07:31]   Plugins/WorldEdit/functions.lua(320): ReplaceBlocksInCuboid
[12:07:31]   Plugins/WorldEdit/Commands/Region.lua(513): (no name)
[12:07:31] Stack trace end
[12:07:31] Error in <attached> calling function <callback>()

[madmaxoft]

Wow, even the error message is corrupt, the argument index is wildly out of range. This is interesting stuff.

[mathiascode]

This is an interesting issue. Sometimes the server crashes, sometimes it only returns an error message.

Related: #26

[mathiascode]

The server no longer crashes, and a proper error message shows up in the console. #26 should still be implemented.