[Bug]: auto-created family provider does not inherit runtimeConfigRef from other providers

[markphillips100]

Is there an existing issue for this?

• I have searched the existing issues

Affected Resource(s)

provider.pkg.crossplane.io/v1

Resource MRs required to reproduce the bug

apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
  name: provider-azure-family-config
spec:
  deploymentTemplate:
    spec:
      selector: {}
      template:
        metadata:
          labels:
            azure.workload.identity/use: "true"
        spec:
          serviceAccountName: "someservicename"
          containers:
            - name: package-runtime
              args:
                - --enable-external-secret-stores
                - --enable-management-policies
---
apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
  name: provider-azure-storage
spec:
  package: xpkg.upbound.io/upbound/provider-azure-storage:0.42.1
  runtimeConfigRef:
    name: provider-azure-family-config

Steps to Reproduce

1. Create a new DeploymentRuntimeConfig with a name other than "default"
2. Reference the config in a specific azure child Provider using runtimeConfigRef, e.g. xpkg.upbound.io/upbound/provider-azure-storage.
3. Wait for the provider to be ready and also the automatically created family provider.
4. Describe the family provider and check what named runtimeConfig it references.

What happened?

When the family provider is created automatically by creating a child provider, it does not inherit the runtimeConfigRef of the child providers.

Relevant Error Output Snippet

No response

Crossplane Version

1.15.0

Provider Version

0.42.1

Kubernetes Version

1.28.0

Kubernetes Distribution

KinD

Additional Info

Two options are possible to resolve currently:

1. Create a Provider explicitly for the xpkg.upbound.io/upbound/provider-family-azure and specify the required runtimeConfigRef.
2. Change the name of the DeploymentRuntimeConfig to "default" so it overrides the existing, and do not specify a runtimeConfigReg in any of the child providers.

[github-actions]

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[github-actions]

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

[kristeey]

/fresh

[kristeey]

I have a similar issue.
I need to disable prometheus scraping for the provider pods. When adding prometheus.io/scrape: "false" to the DeploymentRuntimeConfig for the child provider, it is not inherited by the parent provider (family provider). This specific case was introduced by this PR crossplane/crossplane#5529 .

It seems somewhat awkward to have to add the parent provider as code with its own DeploymentRuntimeConfig just to make this work. Moreover... it feels awkward that one have to add a DeploymentRuntimeConfig to disable this in the first place

[ronen770]

Not sure why this was closed. I am facing a similar issue when adding DeploymentRuntimeConfig to provider-azure-containerservice in order to add proxy environment variables.

I am trying to create a "Resource Group" which seems to be deployed from from the provider-azure-family and thus does not succeed as there is no proxy config

[ronen770]

Not sure why this was closed. I am facing a similar issue when adding DeploymentRuntimeConfig to provider-azure-containerservice in order to add proxy environment variables.

I am trying to create a "Resource Group" which seems to be deployed from from the provider-azure-family and thus does not succeed as there is no proxy config

Anyone with a similar issue, i found the solution. There is a default DeploymentRuntimeConfig created which is referenced by the family providers. So you just need to edit this to add your spec