Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade integration testing framework for v50 #1349

Closed
3 tasks
Tracked by #1246
MSalopek opened this issue Oct 11, 2023 · 2 comments · Fixed by #1367 or #1398
Closed
3 tasks
Tracked by #1246

upgrade integration testing framework for v50 #1349

MSalopek opened this issue Oct 11, 2023 · 2 comments · Fixed by #1367 or #1398
Assignees
@MSalopek
Labels
S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Oct 11, 2023 •
edited
Loading

v50 upgrade requires changes to integration testing setup.

Namely, packet sniffing that was done as part of legacy_ibc_testing directory removal needs to be refactored to support the new ABCIListener interface and the changes requried to support FinalizeBlock since ABCI++ (CometBFT v0.38) does not support BeginBlock and EndBlock any more.

Previous and related issues:

Prerequisites

Work is partially done on feat/v50-upgrade.

To complete this issue all testing apps (app.go and related cmd) must be made operational.

Partial fixes enabling more work

Closing criteria

  • refactor integration testing setup in tests/integration/setup.go (support new interfaces, update packet/event sniffing)
  • enable e2e tests and make them pass, refactoring where necessary
  • PRs made to feat/v50-upgrade
@MSalopek MSalopek mentioned this issue Oct 11, 2023
Closed
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Oct 11, 2023
@MSalopek MSalopek added S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring labels Oct 11, 2023
@MSalopek MSalopek moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Oct 11, 2023
@MSalopek MSalopek changed the title upgrade integration testing framework upgrade integration testing framework for v50 Oct 11, 2023
@MSalopek MSalopek assigned MSalopek and unassigned MSalopek Oct 11, 2023
@MSalopek MSalopek mentioned this issue Oct 17, 2023
Merged
@MSalopek MSalopek linked a pull request Oct 17, 2023 that will close this issue
tests: cleanup integration tests #1367
Merged
tbruyelle added a commit to allinbits/interchain-security that referenced this issue Nov 7, 2023
@tbruyelle
test: upgrade packetSniffer to latest ABCIListener API
4abafd7 
Closes: cosmos#1349

Also remove unused func ABCIToSDKEvents.
@tbruyelle tbruyelle mentioned this issue Nov 8, 2023
Merged
tbruyelle added a commit to allinbits/interchain-security that referenced this issue Nov 8, 2023
@tbruyelle
test: upgrade packetSniffer to latest ABCIListener API
335cd90 
Relates: cosmos#1349

Also remove unused func ABCIToSDKEvents.
@MSalopek MSalopek mentioned this issue Nov 8, 2023
Closed
MSalopek pushed a commit that referenced this issue Nov 8, 2023
@tbruyelle
test: upgrade packetSniffer to latest ABCIListener API (#1398)
657c063 
test: upgrade packetSniffer to latest ABCIListener API

Relates: #1349

Also remove unused func ABCIToSDKEvents.
@MSalopek MSalopek linked a pull request Nov 8, 2023 that will close this issue
test: upgrade packetSniffer to latest ABCIListener API #1398
Merged
@MSalopek MSalopek mentioned this issue Nov 9, 2023
Closed
@mpoke
Copy link
Contributor

mpoke commented Jan 10, 2024

@MSalopek this issue seems to have been fixed. Is that right?

@MSalopek MSalopek moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Apr 3, 2024
@MSalopek
Copy link
Contributor Author

Closing as the solution is in release/v5.x.

Commits:

@github-project-automation github-project-automation bot moved this from 🏗 F3: InProgress to 👍 F4: Assessment in Cosmos Hub Apr 23, 2024
@MSalopek MSalopek self-assigned this Apr 23, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
2 participants
@mpoke @MSalopek