Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with the Libcontainer trait for build_container to something like open_stdio #243

Closed
jsturtevant opened this issue Aug 16, 2023 · 3 comments · Fixed by #293
Closed

Experiment with the Libcontainer trait for build_container to something like open_stdio #243

jsturtevant opened this issue Aug 16, 2023 · 3 comments · Fixed by #293
Assignees
@jprendes
Labels
enhancement New feature or request

Comments

@jsturtevant
Copy link
Contributor 

          `build_container` seems like a fairly heavy trait function.

I think if we add something like open_stdio to the trait we can implement common build_container?

Originally posted by @cpuguy83 in #226 (comment)
@jsturtevant jsturtevant changed the title Experiment with the Libcontainer trait for build_container to something like open_stdioo be something like Experiment with the Libcontainer trait for build_container to something like open_stdio Aug 16, 2023
@jsturtevant
Copy link
Contributor Author

This might help with #240 as well

@jprendes jprendes self-assigned this Aug 16, 2023
@Mossaka
Copy link
Member

Mossaka commented Aug 16, 2023

The question is - do we want shim authors to be able to build their customized Container using Container's builder methods?

@jsturtevant
Copy link
Contributor Author

jsturtevant commented Aug 22, 2023 •
edited
Loading

There is an approach in #250 that simplifies this

@Mossaka Mossaka linked a pull request Aug 23, 2023 that will close this issue
[rfc] Add simplified libcontainer instance API #250
Closed
@Mossaka Mossaka added the enhancement New feature or request label Aug 24, 2023
@Mossaka Mossaka linked a pull request Sep 5, 2023 that will close this issue
Provide a simplified API when using libcontainer #293
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprendes jprendes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jsturtevant @jprendes @Mossaka