Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ttrpc-rust as sub-project #33

Closed
teawater opened this issue Oct 9, 2019 · 15 comments
Closed

Adding ttrpc-rust as sub-project #33

teawater opened this issue Oct 9, 2019 · 15 comments

Comments

@teawater
Copy link

teawater commented Oct 9, 2019

We just open source our ttrpc-rust implementation in https://github.com/alipay/ttrpc-rust and https://crates.io/crates/ttrpc .
We would like add it as sub-project of containerd.

Please help us about the process. Thanks!

@crosbymichael
Copy link
Member

What are you thoughts on who will maintain this project after the move?

@teawater
Copy link
Author

What are you thoughts on who will maintain this project after the move?

@gnawux Do you have any idea on this?

@teawater
Copy link
Author

teawater commented Oct 10, 2019

What are you thoughts on who will maintain this project after the move?

@crosbymichael We (kata team in antfin) will keep maintain this project. But we are open to contributions.
Do you have any opinions?

@crosbymichael
Copy link
Member

crosbymichael commented Oct 23, 2019

That works. Do we want this as a separate repo or part of the TTRPC repo?

@estesp
Copy link
Member

estesp commented Oct 23, 2019

Given our governance, it would make sense to have it be its own non-core repo so that it can have its own maintainers who don't need to worry about the rest of the org. core repos.

Also, seems like a project using a different programming language would just be cleaner as its own repo with its own CI, Makefile, scripts, etc. which I assume will not be aligned with the rest of the Golang-focused repos. It can also be tagged and released on its own timeline as well as a separate repo.

@teawater
Copy link
Author

teawater commented Nov 4, 2019

@crosbymichael I think comments from @estesp is what I think about.
What do you think about let ttrpc-rust as a separate repo?

@crosbymichael
Copy link
Member

@teawater that works for me. Sounds good!

@estesp
Copy link
Member

estesp commented Nov 4, 2019

@crosbymichael should we open a separate issue with a formal proposal for a vote? I think other than what we already know about the project, we would want a list of potential maintainers (so far @teawater is the only contributor to the existing project I think?) and agreement to add the boilerplate re: CNCF code of conduct and containerd governance.

@crosbymichael
Copy link
Member

Ya, i was thinking all we need now is a formal proposal with the list of maintainers and the repo up to spec with the boilerplate

@teawater
Copy link
Author

Thanks @estesp @crosbymichael

Are there any previous proposals could be used as references?

PS: @lifupan may be a second maintainer for the project.

@crosbymichael
Copy link
Member

You can look at #37

@AkihiroSuda
Copy link
Member

@teawater Do you want to call for votes?

@teawater
Copy link
Author

teawater commented Dec 5, 2019

@AkihiroSuda yes.

@AkihiroSuda
Copy link
Member

@teawater could you open an issue for voting as in #37 ?

@teawater
Copy link
Author

I have raised the proposal/voting in #40 and I think this issue could be closed.

Thanks @estesp @crosbymichael and @AkihiroSuda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants