- | {{getReviewFieldData(reviewField.id, 'label')}} |
+ ng-if="additionalDetails.selectedReviewFields.length > 0 && isTruthy(getReviewFieldData(reviewField.id, 'is_active'))">
+
+ {{getReviewFieldData(reviewField.id, 'label')}}
+ |
{
beforeEach(() => {
createController({ ifNewAward: false });
+ $scope.reviewFields = ReviewFieldsMockData;
$scope.awardStages = CaseStatus.getAll();
$scope.basicDetails.selectedAwardStages = { 1: true };
@@ -398,6 +399,30 @@
});
});
});
+
+ describe('when editing an award with a disabled review field', () => {
+ beforeEach(() => {
+ createController({ ifNewAward: false });
+ $scope.reviewFields = ReviewFieldsMockData;
+ $scope.awardStages = CaseStatus.getAll();
+ $scope.basicDetails.selectedAwardStages = { 1: true };
+
+ setAwardDetails();
+ ReviewFieldsMockData[0].is_active = '0';
+ $scope.saveAwardInBG();
+ $scope.$digest();
+ });
+
+ afterEach(() => {
+ ReviewFieldsMockData[0].is_active = '1';
+ });
+
+ it('removes the disabled field while saving the additional award details', () => {
+ expect(civicaseCrmApi).toHaveBeenCalledWith('AwardDetail', 'create', jasmine.objectContaining({
+ review_fields: []
+ }));
+ });
+ });
});
describe('when saving a new award', () => {
@@ -405,6 +430,7 @@
beforeEach(() => {
createController({ ifNewAward: true, redirectTo: 'dashboard' });
setAwardDetails();
+ $scope.reviewFields = ReviewFieldsMockData;
$scope.saveNewAward();
$scope.$digest();
@@ -423,6 +449,7 @@
beforeEach(() => {
createController({ ifNewAward: true, redirectTo: 'workflow' });
setAwardDetails();
+ $scope.reviewFields = ReviewFieldsMockData;
$scope.saveNewAward();
$scope.$digest();
@@ -443,6 +470,7 @@
beforeEach(() => {
createController({ ifNewAward: true, redirectTo: 'dashboard' });
setAwardDetails();
+ $scope.reviewFields = ReviewFieldsMockData;
$scope.saveAndNavigateToPreviousPage();
$scope.$digest();
@@ -468,6 +496,7 @@
beforeEach(() => {
createController({ ifNewAward: true, redirectTo: 'workflow' });
setAwardDetails();
+ $scope.reviewFields = ReviewFieldsMockData;
$scope.saveAndNavigateToPreviousPage();
$scope.$digest();
diff --git a/ang/test/civiawards/award-creation/directives/review-fields/review-fields-table.directive.spec.js b/ang/test/civiawards/award-creation/directives/review-fields/review-fields-table.directive.spec.js
index f2527d86..ec04ca3e 100644
--- a/ang/test/civiawards/award-creation/directives/review-fields/review-fields-table.directive.spec.js
+++ b/ang/test/civiawards/award-creation/directives/review-fields/review-fields-table.directive.spec.js
@@ -89,6 +89,50 @@
expect($scope.additionalDetails.selectedReviewFields).toEqual([]);
});
});
+
+ describe('and the review field is disabled', () => {
+ beforeEach(() => {
+ ReviewFieldsMockData[0].is_active = '0';
+ });
+
+ afterEach(() => {
+ ReviewFieldsMockData[0].is_active = '1';
+ });
+
+ describe('and the review was not selected before', () => {
+ beforeEach(() => {
+ $scope.additionalDetails = { selectedReviewFields: [] };
+
+ $scope.toggleReviewField(ReviewFieldsMockData[0]);
+ });
+
+ it('does not addd the clicked review field as selected', () => {
+ expect($scope.additionalDetails.selectedReviewFields).toEqual([]);
+ });
+ });
+
+ describe('and the review was selected before', () => {
+ beforeEach(() => {
+ $scope.additionalDetails = {
+ selectedReviewFields: [{
+ id: ReviewFieldsMockData[0].id,
+ required: false,
+ weight: 1
+ }]
+ };
+
+ $scope.toggleReviewField(ReviewFieldsMockData[0]);
+ });
+
+ it('does not remove the clicked review field from selected', () => {
+ expect($scope.additionalDetails.selectedReviewFields[0]).toEqual({
+ id: ReviewFieldsMockData[0].id,
+ required: false,
+ weight: 1
+ });
+ });
+ });
+ });
});
describe('when the REMOVE button is clicked from the review field list', () => {
|