Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't consider internal libraries? #41

Open
tfausak opened this issue Apr 26, 2024 · 2 comments
Open

Doesn't consider internal libraries? #41

tfausak opened this issue Apr 26, 2024 · 2 comments

Comments

@tfausak
Copy link

tfausak commented Apr 26, 2024

I was recently pinged to update one of my packages (burrito) to allow QuickCheck 2.15: commercialhaskell/stackage#7391

Curiously I wasn't pinged to update another one of my packages (saturn), even though it's also in Stackage and depends on QuickCheck < 2.15. After thinking about it for a minute, I realized that saturn depends on QuickCheck in one of its internal libraries (namely saturn:lib:spec): https://github.com/tfausak/saturn/blob/1.0.0.3/saturn.cabal#L81

Is that a problem for this curator tool? I wasn't sure where to report this issue.

@mihaimaruseac
Copy link

There is some long-standing Stack issue, I think. We have commercialhaskell/stackage#4475 for curator and commercialhaskell/stack#4148 on stack. Maybe more, but these are the ones I know of, I need to find some long time to look into them

@mpilgrem
Copy link
Member

commercialhaskell/stack#4148 is specific to stack ghci. stack build 'proper' should work with sub-libraries, since Stack 2.15.1. However, you can't specify a public sub-library as an isolated build target with Stack, because Stack still approaches building in terms of 'packages (with components)' rather than 'components (of packages)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants