You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the OSBAPI spec the broker may create the service instance binding synchronously and respond with 201 Created. The spec does not make it clear if getting last operation status will be possible in this case. Some brokers may not be serving the service instance binding last operation endpoint for synchronous creates, so we should make sure we only get last operation when the broker responeded with 202 Accepted and fetch the binding via GET /v2/service_instances/:instance_id/service_bindings/:binding_id otherwise.
Acceptance
GIVEN a managed CFServiceInstance and CFServiceBining resources are created WHEN the broker responds with 201 Created to the PUT /v2/service_instances/:instance_id/service_bindings/:binding_id request THEN the CFServiceBinding becomes ready and the binding credentials secret is available in its status AND no GET /v2/service_instances/:instance_id/service_bindings/:binding_id/last_operation request was sent to the OSBAPI broker
Dev Notes
As the synchronous/asynchronous nature of the OSBAPI request is a low level implementation detail it is not practical to write high level tests (e2e/smoke) for this feature. Instead we should test it with a controller test, where the OSBAPI client is a fake, which makes it easy to check what requests have been performed against the broker
The text was updated successfully, but these errors were encountered:
Only synchronous binds are supported
fixes#3482
Co-authored-by: Danail Branekov <danailster@gmail.com>
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Only synchronous binds are supported
fixescloudfoundry#3482
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Co-authored-by: Danail Branekov <danailster@gmail.com>
Only synchronous binds are supported
fixes#3482
Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Co-authored-by: Danail Branekov <danailster@gmail.com>
Background
According to the OSBAPI spec the broker may create the service instance binding synchronously and respond with
201 Created
. The spec does not make it clear if getting last operation status will be possible in this case. Some brokers may not be serving the service instance binding last operation endpoint for synchronous creates, so we should make sure we only get last operation when the broker responeded with202 Accepted
and fetch the binding viaGET /v2/service_instances/:instance_id/service_bindings/:binding_id
otherwise.Acceptance
GIVEN a managed CFServiceInstance and CFServiceBining resources are created
WHEN the broker responds with
201 Created
to thePUT /v2/service_instances/:instance_id/service_bindings/:binding_id
requestTHEN the CFServiceBinding becomes ready and the binding credentials secret is available in its status
AND no
GET /v2/service_instances/:instance_id/service_bindings/:binding_id/last_operation
request was sent to the OSBAPI brokerDev Notes
The text was updated successfully, but these errors were encountered: