As a Korifi API user I want to be able to unbind from a managed service instance

[danail-branekov]

GIVEN I have bound an app to a managed service
WHEN I DELETE /v3/service_credential_bindings/my-binding-guid
THEN I get a 202 Accepted response with Location header ppointing me to a binding deletion job
THEN eventually I see the binding deletion job to succeed
THEN binding data should not be available to the app (after a restart/restage) any more

Dev notes:

• The implementation should call Unbind on the service broker

• When requesting unbind from the broker, the implementation should send the accepts_incomplete=true query parameter to enable async unbind

• When the broker accepts the request (responds either with 200 OK or 202 Accepted, the implementation must not check for binding last operation and must remove the finalizer.

• If the operation succeeds, the CFServiceBinding along its credentials secrets should be deleted

• If the operation fails, the failure should be reflected in the CFServiceBinding status

• Unbind OSBAPI docs

• Synchronous vs asynchronous operations OSBAPI docs

• Managed services proposal

• Delete service binding docs

[georgethebeatle]

The way we finalize managed service bindings in this story seems to be causing pollution in CI environments. In order to prevent reverting the whole change, we decided to just revert the finalization logic and replace it with a no-op finalizer. Therefore we re-open this story as a reminder to re-introduce finalization logic for cfservicebindings.