Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push app env var related code into the env builder #3168

Closed
georgethebeatle opened this issue Mar 14, 2024 · 0 comments
Closed

Push app env var related code into the env builder #3168

georgethebeatle opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
chore good first issue Good for newcomers

Comments

@georgethebeatle
Copy link
Member

georgethebeatle commented Mar 14, 2024

Blockers

#3165 : This PR introduces a MEMORY LIMIT env var that can also be pushed into the env builder

Background

In the CFProcess controller we are currently building a subset of the needed environment via an env builder and the rest is being appended at a later point. We could improve this by pushing all code that builds env vars into the env builder. The env buidler will have to take cfprocess as an additional argument.

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Mar 14, 2024
@georgethebeatle georgethebeatle added the good first issue Good for newcomers label Mar 14, 2024
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🔄 In progress in Korifi - Backlog Apr 2, 2024
@danail-branekov danail-branekov moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants