CFApp controller should not manage VCAP_SERVICES

[georgethebeatle]

Background

The CFApp controller is currently managing VCAP_SERVICES by watching CFServiceBindings. All service binding management should be a responsibility of the CFBindingController. The app controller should not care about service bindings and should not get triggered by them.

Dev Notes:

• Once we give the responsibility of VCAP_SERVICES management to the servicebinding controller we will need to introduce a finalizer to the CFServiceBinding resource so that the controller rebuilds the VCAP_SERVICES secret on binding deletion.
• According to the servicebinding.io spec it is possible to project secrets as env vars in the workload. We could leverage this capability and delete our own code that deals with env var injection in our app workload.

[georgethebeatle]

On a second thought this issue does not make much sense, as the binding controller is reponsible for just one binding, while the app is what aggregates all its bindings in its environment. Therefore looks like the app controller is the appropriate place for such aggregation.