Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Korifi user I want to see the app status as "crashed" when my app exits #3082

Closed
georgethebeatle opened this issue Jan 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@georgethebeatle
Copy link
Member

georgethebeatle commented Jan 26, 2024

Acceptance

GIVEN I have pushed a crashing app
WHEN I get the app via cf app my-app
THEN I eventually see the state of the app as crashed

@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Jan 26, 2024
@danail-branekov danail-branekov added the bug Something isn't working label Jan 26, 2024
@danail-branekov danail-branekov moved this from 🧊 Icebox to 🔄 In progress in Korifi - Backlog Jan 26, 2024
danail-branekov added a commit that referenced this issue Jan 26, 2024
Looking at the terminated state of a container is not reliable as this
state does not last very long. Once a workload container exits
(regardless of the exit code) consistently, k8s puts the container into
`Waiting` state with reason `CrashLoopBackOff` until the scheduler
starts it again. As this is an exponential backoff, this state tends to
last longer and longer if the app keeps crashing.

With the previous implementation of looking at the `Terminated` state we
could never see the instance as `crashed` in the `cf app` output when we
intentionally kept crashing it.

Issue: #3082

Co-authored-by: Danail Branekov <danailster@gmail.com>
danail-branekov added a commit that referenced this issue Jan 26, 2024
Looking at the terminated state of a container is not reliable as this
state does not last very long. Once a workload container exits
(regardless of the exit code) consistently, k8s puts the container into
`Waiting` state with reason `CrashLoopBackOff` until the scheduler
starts it again. As this is an exponential backoff, this state tends to
last longer and longer if the app keeps crashing.

With the previous implementation of looking at the `Terminated` state we
could never see the instance as `crashed` in the `cf app` output when we
intentionally kept crashing it.

Issue: #3082

Co-authored-by: Danail Branekov <danailster@gmail.com>
@github-project-automation github-project-automation bot moved this from 🔄 In progress to ✅ Done in Korifi - Backlog Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants